Conversation
Contributor
minmin02
commented
Nov 2, 2025
minmin02
commented
- 워크북 실습 ( test 진행)
- ReviewException을 통한 예외처리
- global에서 만든 성공 메서드 추가
ggamnunq
reviewed
Nov 11, 2025
| .orElseThrow(() -> new ReviewException(ReviewErrorCode.MEMBER_NOT_FOUND)); | ||
|
|
||
| // 평점값 유효성 검사 | ||
| if (rating != null && (rating < 1 || rating > 5)) { |
There was a problem hiding this comment.
null인 것과 페이지 유효성 검사는 나누는게 좋을듯 합니다.
이렇게 두면 null이어서 안되는건지, 값이 잘못된건지 구분하기 힘들어요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.