Conversation
Closed
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kwonminsooo
changed the title
choehyeonjin
requested review from
catomat0,
choehyeonjin,
hajimeong and
ownue
3 tasks
choehyeonjin
added a commit
that referenced
this pull request
Feb 11, 2026
[FIX] 프로필 조회 응답에 이메일/소셜 정보 추가
Collaborator
|
최신 develop 브랜치로 업데이트 부탁드립니다! |
Collaborator
Author
업데이트 완료하였습니다! |
catomat0
approved these changes
Feb 11, 2026
Comment on lines
132
to
137
| private String buildCloudFrontUrl(String key) { | ||
| String cf = props.cloudfrontDomain(); | ||
| if (cf == null || cf.isBlank()) { | ||
| throw new GeneralException(S3ErrorCode.EMPTY_KEY); | ||
| } | ||
| String base = cf.endsWith("/") ? cf.substring(0, cf.length() - 1) : cf; |
Collaborator
There was a problem hiding this comment.
EMPTY_KEY 보단 만드신 CLOUDFRONT_FAILED 가 나중에 에러 찾기 쉬울거같습니다
Comment on lines
47
to
50
| region: ${AWS_REGION} | ||
| access-key: ${AWS_ACCESS_KEY_ID} | ||
| secret-key: ${AWS_SECRET_ACCESS_KEY} | ||
| enabled: true |
Collaborator
There was a problem hiding this comment.
액세스키랑 시크릿키 사용안하시면 두개 필드 삭제해주시고 노션 환경변수파일도 수정 부탁드립니다!
catomat0
added a commit
that referenced
this pull request
Feb 11, 2026
* chore: OCR result DTO 패키지 분리 * [CHORE] Auth 파트 정리 및 계층 정리 (#161) * Chore: 명세서 성공 응답으로 통일 수정 * Chore: 리다이렉트 url 기본값 변경 * Remove: infra/redis 삭제 * Chore: auth파트 DTO 분리 --------- Co-authored-by: catomat0 <catomat0@github.com> * [REFACTOR]이미지 업로드 api (cloudfront) (#150) * [refactor]cloudfront 방식으로 변경 * [refactor]이미지업로드 cloudfront 방식으로 변경 * test-yaml 수정 * pull * application yaml 수정 * 리뷰 수정 * dto request response result 분리 * fix 오류 수정 * controller 수정 --------- Co-authored-by: choehyeonjin <guswls2616@naver.com> Co-authored-by: 하지명 <104803823+hajimeong@users.noreply.github.com> Co-authored-by: catomat0 <catomat0@github.com> Co-authored-by: kwonminsooo <118319151+kwonminsooo@users.noreply.github.com>
catomat0
added a commit
that referenced
this pull request
Feb 12, 2026
* chore: OCR result DTO 패키지 분리 * chore: Analyze result DTO 패키지 분리 * [CHORE] Auth 파트 정리 및 계층 정리 (#161) * Chore: 명세서 성공 응답으로 통일 수정 * Chore: 리다이렉트 url 기본값 변경 * Remove: infra/redis 삭제 * Chore: auth파트 DTO 분리 --------- Co-authored-by: catomat0 <catomat0@github.com> * [REFACTOR]이미지 업로드 api (cloudfront) (#150) * [refactor]cloudfront 방식으로 변경 * [refactor]이미지업로드 cloudfront 방식으로 변경 * test-yaml 수정 * pull * application yaml 수정 * 리뷰 수정 * dto request response result 분리 * fix 오류 수정 * controller 수정 * [FIX] 프롬 쿼리문 수정 (#166) * [refactor]cloudfront 방식으로 변경 * [refactor]이미지업로드 cloudfront 방식으로 변경 * test-yaml 수정 * pull * application yaml 수정 * 리뷰 수정 * dto request response result 분리 * fix 오류 수정 * controller 수정 * Fix: 쿼리문 수정 --------- Co-authored-by: Minsu Kwon <kms37480@naver.com> Co-authored-by: catomat0 <catomat0@github.com> --------- Co-authored-by: hajimeong <ha_01@naver.com> Co-authored-by: choehyeonjin <guswls2616@naver.com> Co-authored-by: 하지명 <104803823+hajimeong@users.noreply.github.com> Co-authored-by: catomat0 <catomat0@github.com> Co-authored-by: kwonminsooo <118319151+kwonminsooo@users.noreply.github.com> Co-authored-by: eunwoo <enu_i@naver.com> Co-authored-by: Minsu Kwon <kms37480@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 개요
🔗 관련 이슈
🛠 변경 사항
✅ 체크리스트