feature/week9 #27
Open
feature/week9 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoo0514
approved these changes
Dec 2, 2024
Collaborator
swoo0514
left a comment
swoo0514
left a comment
There was a problem hiding this comment.
전체적으로 잘 작성하신 것 같습니다! callback_uri가 하드코딩되어있던데 이 부분만 환경변수를 사용하는 방식으로 바꾸면 더 좋을 것 같아요 :)
swoo0514
reviewed
Dec 2, 2024
| import { StatusCodes } from 'http-status-codes'; | ||
|
|
||
| export const handleUpdateUser = async (req, res, next) => { | ||
| const userId = req.params.userId; // userId 추출 |
Collaborator
There was a problem hiding this comment.
userId와 같은 개인정보는 params보다는 body로 넣어서 보내주는 것이 안전해요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존코드가 너무 지저분하여 이번주차 미션부분 새로 만들어서 작업