10주차과제_정 #14
Open
10주차과제_정 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private final PasswordEncoder passwordEncoder; | ||
|
|
||
| @PostMapping("/signup") | ||
| public String signup( |
Collaborator
There was a problem hiding this comment.
지금 방식은 post 요청에서 모든 파라미터를 쿼리 파라미터로 받는 방식을 사용하고 계십니다.
비밀번호나 이메일 등이 쿼리 파라미터로 넘어오고 있기 때문에,
Requestbody 형식으로 dto를 사용해서 받는 방식이 더 좋을 것 같습니다.
| public class QuerydslConfig { | ||
|
|
||
| @Bean | ||
| public JPAQueryFactory jpaQueryFactory(EntityManager entityManager) { |
Collaborator
There was a problem hiding this comment.
중복되는 EntityManager를 빈으로 등록해서, 싱글톤으로 관리하는 방식 좋습니다!
Ochangmin524
approved these changes
Dec 23, 2025
Collaborator
Ochangmin524
left a comment
Ochangmin524
left a comment
There was a problem hiding this comment.
깔끔한 코드 인상깊었습니다
전체적으로 깔끔하게 잘 작성해주셨습니다!
정말 수고하셨습니다!
|
|
||
| jwt: | ||
| token: | ||
| secretKey: umc-9th-springboot-jwt-secret-key-256bit-over |
Collaborator
There was a problem hiding this comment.
jwt 시크릿 키는 공유되어서는 안되기 때문에, 깃에 공유되어서는 안됩니다.
깃 시크릿이나 .env 로 관리하는 방법 추천드립니다.
추후 현재 키값은 수정해주시면 감사하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10주차 과제입니다.