feat(rendered): Support rendered resources #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+112
to
+172
| let options = match &request.parameters.window { | ||
| Some(windowing) => ConvertOptions::new() | ||
| .with_voi_lut(VoiLutOption::Custom(WindowLevel { | ||
| center: windowing.center, | ||
| width: windowing.width, | ||
| })) | ||
| .force_8bit(), | ||
| None => ConvertOptions::default().force_8bit(), | ||
| }; |
Check warning
Code scanning / clippy
use Option::map_or_else instead of an if let/else Warning
Comment on lines
+112
to
+172
| let options = match &request.parameters.window { | ||
| Some(windowing) => ConvertOptions::new() | ||
| .with_voi_lut(VoiLutOption::Custom(WindowLevel { | ||
| center: windowing.center, | ||
| width: windowing.width, | ||
| })) | ||
| .force_8bit(), | ||
| None => ConvertOptions::default().force_8bit(), | ||
| }; |
Check warning
Code scanning / clippy
use Option::map_or_else instead of an if let/else Warning
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #9
Current behaviour is that the /rendered endpoints return the first renderable instance from the related study / series. According to the specification the behaviour doesn't follow any rules - it must just be documented within the conformance statement
Right for for the windowing the LUT function is ignored, since my PR is not in a released
dicom-rsversion yet: Enet4/dicom-rs#598