Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BXC-4807/4757/4799 - Thumbnail size, linking, and pagination. Admin spacing #1856

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

bbpennel
Copy link
Member

@bbpennel bbpennel commented Dec 24, 2024

https://unclibrary.atlassian.net/browse/BXC-4757
https://unclibrary.atlassian.net/browse/BXC-4807
https://unclibrary.atlassian.net/browse/BXC-4799

  • BXC-4757 - Change thumbnail sizes from 64px and 128px to 160px and 250px.
    • Thumbnail component now defaults to medium size, where both medium and small use the 'small' thumbnail image size.
    • Only the gallery view uses large at the moment, whereas before everything used large
  • BXC-4807 - Add asLink attribute for thumbnails to allow thumbnails to not be links, set this attribute for full record thumbnails
  • Convert pagination to using bulma component. Always shows 7 pages now, if there are at least 7 pages
  • BXC-4799 - Spacing fixes for admin ui and dead code cleanup

…ks, set this attribute for full record thumbnails
…ail component now defaults to medium size, where both medium and small use the 'small' thumbnail image size. Only the gallery view uses large at the moment, whereas before everything used large
@bbpennel bbpennel changed the title BXC-4807/4757 - Thumbnail size, linking, and pagination BXC-4807/4757/4799 - Thumbnail size, linking, and pagination. Admin spacing Dec 24, 2024
Copy link
Contributor

@lfarrell lfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just a couple of very minor changes.

static/js/vue-cdr-access/tests/unit/pagination.spec.js Outdated Show resolved Hide resolved
static/js/vue-cdr-access/tests/unit/pagination.spec.js Outdated Show resolved Hide resolved
static/js/vue-cdr-access/src/components/pagination.vue Outdated Show resolved Hide resolved
@lfarrell lfarrell merged commit 89b8243 into main Jan 7, 2025
5 checks passed
@lfarrell lfarrell deleted the bxc-4807 branch January 7, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants