Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BXC-4801 - Fix PDF viewer errors #1866

Merged
merged 5 commits into from
Jan 15, 2025
Merged

BXC-4801 - Fix PDF viewer errors #1866

merged 5 commits into from
Jan 15, 2025

Conversation

bbpennel
Copy link
Member

@bbpennel bbpennel commented Jan 14, 2025

https://unclibrary.atlassian.net/browse/BXC-4801

  • Prevents errors on full record page controller endpoints if the user accesses a work with a PDF file, but that PDF file is not accessible
  • Prevents error is pdfViewer endpoint is accessed for a non-PDF file.
  • When setting up pdf viewer property for full record responses, ensure that the user has permission to view the PDF file. If a pdf view is requested for a non-pdf file, then clear the viewer settings.
  • Adds a unit test for partial coverage of full record controller

@krwong krwong merged commit 1195ee5 into main Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants