Merge dev branch into master #2

mishaturnbull · 2019-01-26T05:40:27Z

PR to merge the previously unstable changes into the master branch. Worth some discussion. Almost 500(?) commits to merge -- not sure if this is worth the added effort for testing.

[fix] fixed deprecated method reflection references.

- thrust now counts motors on InnerTubes AND BodyTubes.

…ComponentAssemblyConfig' class

- update ParallelStage#update to use the parent-class which contains 'getOuterRadius'

Bugfix Aggregation: release-candidate-0

…le class (and implementations)

…ed+rotated components - introduced interfaces for different types of positionable components: -- AnglePositionable -- AxialPositionable -- RadiusPositionable - RingInstanceable now includes these other interfaces, making explicit the expectations of any implementing subclass. - RingInstanceable now indicates its angles as an array instead of returning angles one-at-a-time -- commit includes updates to match this new API - Added getAssembly() method to RocketComponent, to simplify instancing code

Fixes Issues: - openrocket#366 - openrocket#323 - RocketFigure no longer draws specific stages: Starts drawing rocket, and then propogates location, angle/transformation downwards - fixed active/inactive visibility toggling - Fixed Drowing Bounds for RocketFigure - Fix: FlightConfiguration#getBounds() - Fix: FinSet#getComponentBounds() - Fix: InnerTube#getInstanceCount() - Add: Coordinate#MIN, Coordinate#MAX - Add: net.sf.openrocket.util.BoundingBox - RocketComponent: - implement: #getInstanceLocations() // relative to parent component - implement #getInstanceAngles() - implement: #getComponentLocations() (Refactor/rename of #getLocations() ) - Implement <x>#getInstanceOffsets() // relative to component-reference-point - FinSet - PodSet - ParallelStage - RailButton - InnerTube: - fixed drawing shapes: - TubeShapes - BodyTube - Launch Lug - RingComponent (InnerTube, EngineBlock, Coupler) - Finset - Transition - Rail Button

…s for 'FinSet', 'LineInstanceable' Components - PodSet may save/load auto-radial-offset - Fins now save/load - 'instancecount' - 'angularoffset' - 'radialoffset' = 'auto' - RadiusPositionable interface now enforces 'setAutoRadialOffset(...)' - implemented RockeComponentSaver#emitInteger - all LineInstanceable implementers read/write 'instanceseparation' - [fix] RocketComponentSaver now saves 'instancecount' even if 1==instancecount

…ctly (add buttons are greyed-out)

…Configuration change - added check in MassCalculator against last-used FlightConfiguration - removed dead code

…ectly

- Adjusted masscalculater code to not double-count instances (when mass > 0, and instance > 1 ) - RingComponents now correctly calculate their mass again

…eform fins.

- moved 'instancecount' and 'instanceseparation' loading from CenteringRing to RadiusRingComponent - enables both Bulkhead and CenteringRing to load those tags from .ork file

…onfiguration Tab - Actual Fix is at MotorMountTableModel:102: re-added callback to the MotorMount component - cleaned up unused variables in the other panels - Tightened up variable re-use in GUIUtil class -- made several intermediate variables separate, uniquely-named, and final.

…available if motor mounts are present.

This is a relatively major refactor / rewrite of the 3d rendering code. - components geometries are rendered recursively - components inherit parents' transformations ( translation, rotation) - implemented Transformation#toGLMatrix() -- openrocket transformations can be directly fed into Java OpenGL - added: FinSet#getBoundingBox() - improved documentation on RocketComponent Location methods - Refactor RocketRenderer: - render component trees recursively - removed RocketRendere#isDrawn(c) -- return true in all implementations - Refactor ComponentRenderer - renamed variables to be more descriptive - changed RocketComponent#toAbsolute(...) => RocketComponent#getComponentLocations() - Adjust FinRender Code: - Render Single Fin Instance at-a-time - takes in an angle for the instance - assumes the fin is already at it's desired position. - renames 'fs' -> 'finSet'