Skip/Speed up tests, resolve most open issues#67
Open
mdavis-xyz wants to merge 28 commits intoUNSW-CEEM:masterfrom
Open
Skip/Speed up tests, resolve most open issues#67mdavis-xyz wants to merge 28 commits intoUNSW-CEEM:masterfrom
mdavis-xyz wants to merge 28 commits intoUNSW-CEEM:masterfrom
Conversation
…, breaking 4 second data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had some issues open for a while. As discussed, it's hard to merge them confidently, given that the tests take half a day, and some functionality has broken due to changes to nemweb.
So I've worked to streamline the tests and the code itself. Now a test with an empty cache takes 2h30m. It's 1h40m with a full cache.
Some of the tests, I just skipped. I normally hate it when people do that. Although for now, I think it's worth doing temporarily, so that we can check all these other bug fixes and feature additions.
This fixes:
And I include some currently open pull requests:
I know it's bad style to combine so many unrelated issues into one pull request. However given that the master branch is not easily buildable, some of these do work together. Look through this pull request one commit at a time, if you want to see review each change separately.
Aside from the tests now skipped with
@unittest.skip(), all unit tests pass.I increased the minimum Python version to 3.10, from 3.9, because
uvcomplained about a dependency. 3.9 is now deprecated, so I think this is ok.