Skip to content

Conversation

@ghackebeil
Copy link
Contributor

@ghackebeil ghackebeil commented Apr 16, 2025

Addresses #36

  • relaxes version constraint for pandas to include 1.5.x
    • avoid using groupby(...).apply(..., include_groups=False)
  • extend tests to cover get_region_dispatch_summary
    • this was mainly to check that some other groupby statements weren't producing the pandas DeprecationWarning related to this include_groups keyword added in pandas 2.x
  • fix 2 exception messages that weren't passing enough arguments to str.format

Test workflow changes:

  • Update test matrix to include testing with pandas 1.x + numpy 1.x
  • Adding setup-python action to fix issue in macos-latest builds where uv would always use python3.13 (no matter what python-version was enabled)
  • Dropping python 3.8 testing since it is past EOL
  • Adding python 3.13 testing (with a few excludes to avoid unrelated build failures)

@ghackebeil
Copy link
Contributor Author

ghackebeil commented Apr 16, 2025

If it's okay with you, I'll also add another build parameter to test the project on both pandas 1.x and 2.x. I'll wait until I see "workflow approval" on this PR to modify the cicd.yml file and push those changes as well.

@ghackebeil
Copy link
Contributor Author

@nick-gorman: Any chance you have a moment to approve this PR for test workflow?

@ghackebeil ghackebeil force-pushed the pandas_1.5_compatibility branch from 89819f8 to 42e9142 Compare May 21, 2025 00:29
@ghackebeil ghackebeil force-pushed the pandas_1.5_compatibility branch from 42e9142 to b2e751e Compare May 21, 2025 05:16
@ghackebeil
Copy link
Contributor Author

Figured out how to run the action workflows on my fork. Updated description with test workflow changes.

@nick-gorman nick-gorman reopened this Oct 16, 2025
@nick-gorman
Copy link
Member

@ghackebeil Can you push an empty/trivial commit so we can see if that triggers the testing workflow?

@ghackebeil
Copy link
Contributor Author

Sure! Will push something shortly.

@ghackebeil
Copy link
Contributor Author

I need to fix the author on my last commit, sorry. Going to do a force push again to my fork in a moment.

@ghackebeil ghackebeil force-pushed the pandas_1.5_compatibility branch from 5056c9a to 81d26c1 Compare October 16, 2025 23:21
@ghackebeil
Copy link
Contributor Author

Good to go now. Here's a link to where the tests are running on my fork, if that helps (in case they don't run here):
https://github.com/ghackebeil/nempy/actions/runs/18577563489

@ghackebeil
Copy link
Contributor Author

I'll try to figure out what is with the build errors. Things were passing before now.

@ghackebeil
Copy link
Contributor Author

@nick-gorman nick-gorman merged commit 2d3cef0 into UNSW-CEEM:master Oct 22, 2025
26 checks passed
@ghackebeil ghackebeil deleted the pandas_1.5_compatibility branch October 22, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants