Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erin remove nf core #4

Merged
merged 61 commits into from
Dec 7, 2023
Merged

Erin remove nf core #4

merged 61 commits into from
Dec 7, 2023

Conversation

erinyoung
Copy link
Member

Because the latest version of IRMA isn't on CONDA, I removed CONDA from the workflow.
I removed all github action (GA) testing that dealt with AWS - because we don't have that capacity.
I also removed all references to the walkercreek slack channel in nf-core's slack space, because that doesn't exist.
I changed all the nf-core/walkercreek instances to UPHL-BioNGS/walkercreek.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/walkercreek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Nov 29, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 984161e

+| ✅  16 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in meta.yml: #Add a description of all of the variables used as input
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-12-07 19:16:26

@tives82
Copy link
Collaborator

tives82 commented Nov 30, 2023

I have made the necessary changes to pass lint testing and complete the PR checklist. I have tried to be descriptive on the commits.

@erinyoung
Copy link
Member Author

This looks great!

Thank you for fixing this!!!

It looks like I accidentally added in all the @eaDir/* directories that mac creates and I can't delete them. Can you delete them?

@tives82
Copy link
Collaborator

tives82 commented Dec 7, 2023

This looks great!

Thank you for fixing this!!!

It looks like I accidentally added in all the @eaDir/* directories that mac creates and I can't delete them. Can you delete them?

Oh, I was wondering where those @eadir directories come from. I probably added to the number of them as well. I think I have deleted them all now. When I run the below command, they are no longer listed.
find . -name "@eaDir" -type d

@tives82
Copy link
Collaborator

tives82 commented Dec 7, 2023

This looks great!
Thank you for fixing this!!!
It looks like I accidentally added in all the @eaDir/* directories that mac creates and I can't delete them. Can you delete them?

Oh, I was wondering where those @eadir directories come from. I probably added to the number of them as well. I think I have deleted them all now. When I run the below command, they are no longer listed. find . -name "@eaDir" -type d

I also removed a temporary SMB file from the images directory that for whatever reason wasn't previously deleted.

@erinyoung
Copy link
Member Author

Awesome! They still look like they are part of this repo, though. If all fails, we can merge this and then delete the files later.

@tives82 tives82 merged commit e3aa70f into master Dec 7, 2023
7 checks passed
@erinyoung erinyoung deleted the erin-remove-nf-core branch December 15, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants