Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Nextclade v3 and Enhancement of Coverage and Depth Analysis #7

Merged
merged 18 commits into from
Mar 15, 2024

Conversation

tives82
Copy link
Collaborator

@tives82 tives82 commented Mar 14, 2024

Changes and modifications proposed in this Pull Request:

  • Nextclade Modules Updates:
    Updated the NEXTCLADE_VARIABLES, NEXTCLADE_DATASETGET, and NEXTCLADE_RUN modules to Nextclade version 3.0 to leverage the latest enhancements and bug fixes.

  • New Modules for Segment Coverage Analysis found in the assembly_typing_clade_variables subworkflow:
    IRMA_SEGMENT_COVERAGE: Calculates reference length, sequence length, and percent coverage for each segment for a given sample. Output files are placed in the ‘irma_segment_coverage’ directory.
    MERGE_COVERAGE_RESULTS: Aggregates coverage data across all samples into merged_coverage_results.tsv file placed in the ‘irma_segment_coverage’ directory.

  • New Modules for Read Mapping Analysis found in the assembly_typing_clade_variables subworkflow:
    SAMTOOLS_MAPPED_READS: Calculates the number of reads mapped and mean depth for each segment for a given sample. Output files are placed in the ‘samtools_mapped_reads’ directory.
    MERGE_BAM_RESULTS: Aggregates depth analysis data across all samples into merged_bam_results.tsv file placed in the ‘samtools_mapped_reads’ directory.

  • Report Generation found in the assembly_typing_clade_variables subworkflow:
    MERGE_BAM_COVERAGE_RESULTS: This module compiles a comprehensive report from the merged_bam_results.tsv and merged_coverage_results.tsv files. The final report, merged_bam_coverage_results.tsv, is placed in the ‘SUMMARY_REPORTS’ directory.

  • Configuration Fixes:
    Corrected the manifest version within nextflow.config to resolve the "Wrong version printed at runtime" issue.

  • Additional Notes:
    The documentation has been updated to reflect these changes.

tives82 and others added 14 commits March 5, 2024 13:24
…improved workflow efficiency

- Introduce new scripts for calculating percent coverage (calc_percent_cov.py), merging BAM coverage (merge_bam_coverage.py), and related utilities to enhance coverage analysis and result integration.
- Add Nextflow modules for segment coverage analysis, merging BAM coverage results, and other related tasks to streamline workflow processes.
- Update nextflow.config and subworkflow modules for assembly typing and input checking to align with new scripts and enhance overall workflow efficiency and accuracy.
updated version to 2.0.0
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Copy link

github-actions bot commented Mar 14, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aaf2ffe

+| ✅  16 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in meta.yml: #Add a description of all of the variables used as input
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2024-03-14 17:26:39

@erinyoung
Copy link
Member

Is

unknown recognition error type: groovyjarjarantlr4.v4.runtime.LexerNoViableAltException

worrisome?

This prints out when I ran the workflow using your test profile.

Also, you probably want to remove something from your config file because there's this warning:

WARN: Undocumented setting `docker.userEmulation` is not supported any more - please remove it from your config

Copy link

@jwarnn jwarnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code changes and didn't see any issues and I ran a test run which produced the expected output.

@tives82 tives82 merged commit 4cceb7e into master Mar 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants