Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial template for shor for discrete log #3

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

mbeisel
Copy link
Contributor

@mbeisel mbeisel commented Feb 6, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: Patch coverage is 32.83582% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 82.86%. Comparing base (97a5f5f) to head (2513c93).

Files Patch % Lines
app/services/objective_service.py 13.33% 26 Missing ⚠️
app/helperfunctions.py 16.66% 10 Missing ⚠️
app/model/objective_request.py 66.66% 6 Missing ⚠️
...pp/controller/objectiveFns/objective_controller.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   83.04%   82.86%   -0.18%     
==========================================
  Files          12       12              
  Lines         401      467      +66     
  Branches       46       55       +9     
==========================================
+ Hits          333      387      +54     
- Misses         53       63      +10     
- Partials       15       17       +2     
Flag Coverage Δ
unittests 82.86% <32.83%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbeisel mbeisel marked this pull request as ready for review March 21, 2024 12:04
@mbeisel mbeisel merged commit 7fd825a into main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants