Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI template tab extras #31

Merged
merged 6 commits into from
Aug 5, 2024
Merged

UI template tab extras #31

merged 6 commits into from
Aug 5, 2024

Conversation

buehlefs
Copy link
Contributor

@buehlefs buehlefs commented Aug 2, 2024

  • Add icon and group_key attributes to UI template tabs DB models
  • Add attributes in API
  • Add DB Migration
  • Improve names of nested template tab groups

icon is used to display a custom icon for that tab

group is used to establish a nested group containing more tabs

@buehlefs buehlefs requested a review from PhilWun August 2, 2024 08:06
@buehlefs buehlefs mentioned this pull request Aug 2, 2024
Merged
3 tasks
PhilWun
PhilWun approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@PhilWun PhilWun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buehlefs buehlefs marked this pull request as ready for review August 5, 2024 14:29
@buehlefs buehlefs merged commit 397e444 into main Aug 5, 2024
2 checks passed
@buehlefs buehlefs deleted the feature/ui-templ-tab-extras branch August 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWun PhilWun PhilWun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buehlefs @PhilWun