Feature/refactor tab group loading #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-load DEFAULT_UI_TEMPLATE, which stores a ui template id.
Refactor templates service to include more utility methods to be used by other components using ui templates. Templates service now has subscriptions for the current and the default template. Templates service can get default template from Experiment and env vars. Refactor navbar to use the changed templates service. Refactor navbar to only show experiment navigation tabs when an experiment is active. Extract template tab details from plugin sidebar into dedicated component.
buehlefs
commented
Jul 7, 2023
src/app/components/experiment-workspace-detail/experiment-workspace-detail.component.html
Outdated
Show resolved
Hide resolved
src/app/components/experiment-workspace-detail/experiment-workspace-detail.component.ts
Outdated
Show resolved
Hide resolved
src/app/components-small/template-details/template-details.component.ts
Outdated
Show resolved
Hide resolved
src/app/components-small/template-details/template-details.component.ts
Outdated
Show resolved
Hide resolved
buehlefs
commented
Jul 10, 2023
Load initial values from cache if available. Update with new values lazily.
infacc
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring to make reloading ui template tabs more robust on changes in the complete application.
Refactorings:
navigation(likeexperiment-navigationshown in the nav bar but only when no experiment is selected)