Show/change experiment default template in UI #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buehlefs
reviewed
Jul 27, 2023
infacc
commented
Aug 1, 2023
buehlefs
requested changes
Aug 1, 2023
The reload of the experiment was done in the wrong place. Sometimes the experiment template id subject signaled an update before the templateId was updated.
buehlefs
approved these changes
Aug 3, 2023
buehlefs
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Please also rename the html template and sass files to *.dialog.*
There was a problem hiding this comment.
Other dialogs also do not follow this convention. Should I rename them as well?
src/app/dialogs/
├── change-ui-template
│ ├── change-ui-template.component.html
│ ├── change-ui-template.component.sass
│ ├── change-ui-template.component.spec.ts
│ └── change-ui-template.component.ts
├── choose-data
│ ├── choose-data.component.html
│ ├── choose-data.component.sass
│ ├── choose-data.component.spec.ts
│ └── choose-data.component.ts
├── choose-plugin
│ ├── choose-plugin.component.html
│ ├── choose-plugin.component.sass
│ ├── choose-plugin.component.spec.ts
│ └── choose-plugin.component.ts
├── choose-template
│ ├── choose-template.dialog.html
│ ├── choose-template.dialog.sass
│ ├── choose-template.dialog.spec.ts
│ └── choose-template.dialog.ts
├── create-experiment
│ ├── create-experiment.component.html
│ ├── create-experiment.component.sass
│ ├── create-experiment.component.spec.ts
│ └── create-experiment.component.ts
├── delete-dialog
│ ├── delete-dialog.dialog.html
│ ├── delete-dialog.dialog.sass
│ └── delete-dialog.dialog.ts
├── export-experiment
│ ├── export-experiment.component.html
│ ├── export-experiment.component.sass
│ ├── export-experiment.component.spec.ts
│ └── export-experiment.component.ts
└── markdown-help
├── markdown-help.component.html
├── markdown-help.component.sass
├── markdown-help.component.spec.ts
└── markdown-help.component.ts
There was a problem hiding this comment.
For this PR only rename the new dialog. If you want to rename the others (which should be done eventually) please open another PR.
buehlefs
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46