default template sidebar reload #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no template id is provided through the URL parameters the plugin sidebar (in the workspace) reloads on every plugin selection. To prevent the plugin sidebar from reloading plugins every time the selected plugin changes the loadActiveTemplateFromId method is now given the default template id when no template id is given.
When navigating to the experiment info tab the template URL parameter persisted. This might be undesirable when the user navigates back and forth between the info and the workspace tab with a default template set. Without persisting template URL parameter the user is always navigated to the default template when switching from the info to the workspace tab.
buehlefs
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 improvements: