Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selenium automation in Automation Tools #540

Closed
wants to merge 2 commits into from

Conversation

nidhi2026
Copy link

Pull Request for PyVerse 💡

Requesting to submit a pull request to the PyVerse repository.


Issue Title

Please enter the title of the issue related to your pull request.
Enter the issue title here. [Code Addition Request]: Adding selenium automation tool example

  • I have provided the issue title.

Info about the Related Issue

What's the goal of the project?
Describe the aim of the project. Adding a selenium automation example for scraping. IMDB uses js for loading, and traditional scraping tools like BeautifulSoup fail to fetch data fully and efficiently. Selenium is an excellent choice for such scenarios, it mimics human-browser interaction.

  • I have described the aim of the project.

Name

Please mention your name.
Enter your name here. Nidhi

  • I have provided my name.

GitHub ID

Please mention your GitHub ID.
Enter your GitHub ID here. nidhi2026

  • I have provided my GitHub ID.

Email ID

Please mention your email ID for further communication.
Enter your email ID here. nidhi.student.cse22@itbhu.ac.in

  • I have provided my email ID.

Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
Enter your participant role here. GSSOC-ext Contributor

  • I have mentioned my participant role.

Closes

Enter the issue number that will be closed through this PR.
*Closes: #495

  • I have provided the issue number.

Describe the Add-ons or Changes You've Made

Give a clear description of what you have added or modified.
Describe your changes here.
Added code for scraping IMDB Disney movies list, with features
Scrapes Disney movies

  • Movie Title
  • Trailer Link / Video
  • Cover Image
  • List of all Genres of Movie
  • Synopsis - Short Description
  • Storyline of Movie

Extras

  • Added loader to scroll to the bottom of the page to load all contents (that loads through js)

  • Added dialog box dismiss logic to close any unexpectedly opened dialog for ratings etc that hinders element interaction

  • I have described my changes.


Type of Change

Select the type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how your changes have been tested.
Describe your testing process here.
The result is included in the Jupyter Notebook
and also ran pytest as a check

  • I have described my testing process.

Checklist

Please confirm the following:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@github-actions github-actions bot requested a review from UTSAVS26 October 12, 2024 21:14
@UTSAVS26 UTSAVS26 added Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. Status: Review Ongoing 🔄 PR is currently under review and awaiting feedback from reviewers. gssoc-ext hacktoberfest level2 labels Oct 13, 2024
@github-actions github-actions bot force-pushed the main branch 5 times, most recently from 774a759 to f014edc Compare October 31, 2024 02:44
@github-actions github-actions bot force-pushed the main branch 2 times, most recently from 609b090 to c1dc75e Compare November 7, 2024 02:42
In my case I am using chromedriver (Remember the version of your chrome driver should match up with the version of chrome you are using)
and once can use any web browser like firfox, safari, edge, of your choice...

As for chromedriver, you can go to `https://chromedriver.chromium.org/downloads`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nidhi2026 ,
Specifying this link is enough, you dont have to attach the .exe file into the folder. Please remove it and will review it then.
Thanks!

@ruhi47 ruhi47 added the Status: Requested Changes⚙️ Indicates that a reviewer has requested changes to a PR before it can be approved. label Nov 8, 2024
@nidhi2026
Copy link
Author

@ruhi47 I have removed the chromedriver.exe as you suggested. Is it good to go now

@ruhi47 ruhi47 added Status: Approved ✔️ PRs that have passed review and are approved for merging. Status: Ready to Merge🚀 PRs that have been approved and are ready to be merged into the main branch. and removed Status: Requested Changes⚙️ Indicates that a reviewer has requested changes to a PR before it can be approved. Status: Review Ongoing 🔄 PR is currently under review and awaiting feedback from reviewers. labels Nov 8, 2024
@UTSAVS26 UTSAVS26 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. gssoc-ext hacktoberfest level2 Status: Approved ✔️ PRs that have passed review and are approved for merging. Status: Ready to Merge🚀 PRs that have been approved and are ready to be merged into the main branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code Addition Request]: Adding selenium automation tool example
4 participants