Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#003 adding qdlmove #7

Merged
merged 41 commits into from
Oct 24, 2024
Merged

#003 adding qdlmove #7

merged 41 commits into from
Oct 24, 2024

Conversation

nyama8
Copy link
Contributor

@nyama8 nyama8 commented Oct 24, 2024

This pull request is in response to issue #3 and implements the base version of qdlmove which is an application for moving the micrometers and piezos via direct input (e.g. by setting the value directly) and by stepping a specified distance via the keyboard arrow keys (for x and y) or the '-' and '+' keys (for z).

The code is setup with indicated areas to be modified for additional hardware including other types of positioners. Currently two new controllers were added: newportmicrometer.py (for Newport mechanized micrometers via serial port connection) and nidaqpiezo.py (which implements a simplified version of the nipizeojenapy repo for controlling the position of piezos actuated by analog voltage output of an NIDAQ board). The latter controller will be used as a base for simplified piezo scanning as relating to issue #5.

After configuring the qdlmove_micros_and_piezos.yaml file located in qdlmove.config_files to match your specific system, the code is currently configured to handle a single micrometer (xy) and single piezo (xyz), but can be modified for additional hardware as needed. Users can input specific positions and drive the hardware to those positions by GUI, or enable stepping via a GUI element to move the position via the arrow and +/- keys.

NOTE: This branch was based off of the feature-clean-ple branch which is currently being prepared for merging into main in Pull Request #1, which should be merged before this one is finalized. This branch should merge the changes from main (after #1 is resolved) before being merged in. All changes specific to this change are located in the qdlmove folder.

LaneUW and others added 30 commits October 4, 2024 23:14
…s now constructed at the start of each new scan.
…RateCounter classes which broke scan/scope. Initial PLE implementation complete.
…efocusing on enter key and renamed nidaqpiezo for general use.
@nyama8 nyama8 requested a review from ethanqw October 24, 2024 01:11
@nyama8 nyama8 linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link
Member

@ethanqw ethanqw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on magpi setup.

@nyama8 nyama8 merged commit 74eb97d into main Oct 24, 2024
@nyama8 nyama8 deleted the 003-adding-qdlmove branch October 24, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New application qdlmove: micrometer and piezo positioner
5 participants