Open
Conversation
Member
Author
|
bump |
Mole1424
commented
Mar 31, 2026
| ical_event.add( | ||
| "dtend", event.end_time or event.start_time + timedelta(hours=1) | ||
| ) | ||
| ical_event.add("dtend", event.end_time or event.start_time + timedelta(hours=1)) |
Member
Author
There was a problem hiding this comment.
tbh idk why this exists in the diff, but it passes ruff so yay
Mole1424
commented
Mar 31, 2026
Member
Author
Mole1424
left a comment
Mole1424
left a comment
There was a problem hiding this comment.
idk why i have to review to comment on the code but sure
|
I get putting them in the same slot, but does it say which of the days it's on in the actual event circle? Otherwise it's ambiguous |
Member
Author
|
At that point i think the circle would get too clustered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor weekend events to be weekend rather than saturday