Conversation
| revert UnsupportedAsset(asset); | ||
| } | ||
| netAssetDeposits += assetAmount; | ||
| IERC20(assetToken).approve(address(BeefyVaultV7(vaultWrapper.vault()).want()), assetAmount); |
There was a problem hiding this comment.
I think here the approval should be fore vaultWrapper.vault() (The first parameter to approve().
There was a problem hiding this comment.
Should it be the token deposited (if so it's currently correct) or the destination address? I don't have much autocompletion or advices in my IDE
There was a problem hiding this comment.
Also types barely show not sure why
| console.log("Saving contract addresses..."); | ||
| const config = ` | ||
| { | ||
| "rageTrade": "${depository.address}" |
There was a problem hiding this comment.
We currently have only one depository per chain. If we have multiple we would want to first read the depositories file, then add to that, so in this case you should write:
{
"rageTrade": "${depositories.rageTrade}", // just re-writing the existing value
"beefyFinance": "${depository.address}" // write the new depository address
}
Current script would overwrite the rageTrade depository address with the beefy one.
There was a problem hiding this comment.
Would also need to load that depositories.rageTrade from somewhere first?
| } | ||
| vaultWrapper = BeefyWrapper(_vaultWrapper); | ||
| controller = IUXDController(_controller); | ||
| assetToken = address(BeefyVaultV7(vaultWrapper.vault()).want()); |
There was a problem hiding this comment.
want is the asset token in the Beefy vault?
There was a problem hiding this comment.
Yes it's the deposited token (in token idk how to call it)
# Conflicts: # .openzeppelin/unknown-421613.json # test/fixtures/depositoryFixture.ts
# Conflicts: # config/arbitrumgoerli.config.ts
# Conflicts: # config/arbitrumgoerli.config.ts
2 participants
No tested yet