Guard Jetty header writes against _fields NPE#1426
Open
lorlikowski-a11y wants to merge 3 commits intoUdashFramework:masterfrom
Open
Guard Jetty header writes against _fields NPE#1426lorlikowski-a11y wants to merge 3 commits intoUdashFramework:masterfrom
lorlikowski-a11y wants to merge 3 commits intoUdashFramework:masterfrom
Conversation
Author
|
@BartlomiejMichalskiAV proszę przypisz @ddworak |
Wrap HttpServletResponse/streams to ignore Jetty _fields NPE and keep response handling intact.
Stop writes after completion/commit, map NPE to 500, and log full stacktrace for diagnosis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes intermittent NullPointerException in Jetty (Response.setContentType, _fields null) when REST response is written after timeout/recycle. We now ignore that specific NPE on header/content-type writes, keeping the rest of the response flow unchanged.
Why:
Jetty may recycle the response after timeout; header writes can throw NPE and fail the whole request.
Scope:
Minimal change in RestServlet.scala.