Add support for components in both positions of pairs#164
Merged
Conversation
Ukendio
changed the title
Ukendio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you want your pairs to have relation data, you have to put a component ID in the first part of the pair. However this restricts usage for many so this PR will let pairs have relation data as long as at least one ID is a component. The behaviour will be that the type gets inferred as the first ID unless it is a tag and in that case it will return the second ID.
pair(Component, Tag)- relation data is typed as First IDpair(Component, Component)- relation data is typed as First IDpair(Tag, Component)- relation data is typed as Second IDpair(Tag, Tag)- no relation data as the pair is considered a tag