This repository has been archived by the owner on Sep 5, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Cura 8640 PyQt6 upgrade #126
[WIP] Cura 8640 PyQt6 upgrade #126
Changes from 203 commits
d31491e
347d812
9b645cc
31b3cd9
6da36c6
af06af3
f26c884
a1aa1fd
dac1bd3
16d0594
d5636e6
be012ac
130924a
50c820d
41204a6
d9c0254
0a1e22e
cf9b02d
f05c4b7
1c17dcf
ded5f65
2acda38
ef3c09f
2b93fe3
27a16df
7668604
a3521e2
9ea6a24
d800d82
6aeb53f
61e6d11
1596c9e
c411225
244aafc
fb81749
4f31e9a
31d83b0
3b5713d
6a00e04
c5409aa
cea9e32
6fcf45b
02df695
8366d58
e6c5ec2
e4cc458
3ca4096
5b42806
f924a92
f435f08
4c34513
9ff6f96
8765f82
d2a6fdc
af55b97
7069a91
204410b
8ebde81
876a9c5
ab4e531
00ac840
430a30c
7fc10a1
83c2d1b
7f79231
169a556
41c6f7f
2426ed3
a22e34a
fcf59e7
0c3ffdc
68a3f07
dcf1827
c421315
333456c
a01e27c
ad9130f
4fc381e
fcd662c
830f83f
340ca1b
4065958
61bfdce
0c0369d
6b7912a
769cf54
e758457
77b1f22
1be4466
37c90e0
dc3541a
cb38cbc
358feb6
1cc2f35
f4e8bfe
0304192
5e414f6
6403f49
18bf199
4b3646e
b47556a
a61aa11
aed27b0
2a192ed
7617bd9
71a08b1
017361b
5630d8d
10ecda9
eaddb38
5da9ff6
30cc176
3afc8dd
eff223e
8bfd6b4
9416bd8
7dbf50c
1c8dc87
724259d
983b16c
2adfd9e
7530329
cf4d53a
642e0d5
add9036
737507a
7b59f89
fc0943a
a54b886
0467c20
def3dd7
2ce129a
f7a8681
c519c2d
bc8014b
a7c642c
d6f048f
b295605
c9f5377
0fdddc4
6fd59f7
08cb991
b70f4d6
429a59d
7e7504f
c188996
a820bfa
11cc1c2
6f3e76a
43bbb39
b75d669
d4b6f1a
7fa8a7b
523e2e2
8857c21
fb6594a
b1f3753
b06acf2
c1206e5
f256ac6
3289f43
5b602f8
31bed9d
32b6c2b
13917de
0a0f964
fbb8d78
b46afbc
882c1fb
d283d6c
9cf0256
3395e8a
f8dfcbe
d3cb601
f89de3a
814401d
6767872
56c60ee
cd78b1c
07aa071
21261bd
13e9884
d5dbe81
30bda08
867557b
f7914d2
5c1eb16
1f54c16
e6b6406
d17d0d7
adbba85
fa71adb
875adff
b2c9508
3fa9ce0
94e0e83
e430407
27c5987
ae409c0
20492a6
23ef10e
3e5dcc2
e93117d
6566efc
8ba86e4
55cc110
6420efc
e1eadff
c3584ad
7d444d9
a61d06e
fd2ccaa
2584388
4e29550
f5860b9
6bc73ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description doesn't describe anything, really.
Knowing how it's used, I think it's better to go back to using timestamps for this. It would end up something like this, I reckon (untested):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build metadata tag in SemVer is most commonly a increasing version number. But after reading https://semver.org/
And since we now have to manually increase this number in a rundeck job I think a timestamp might be a good intermittent solution before our switch to Conan and Pipelines.
Special care should be taken to make sure that timestamp is used for all three OSes. that requires us to set it in Rundeck and not here.
@evtrados Can you make sure that all three build jobs on Rundeck use the same timestamp ad the CURA_VERSION_BUILD
This file was deleted.
This file was deleted.