Fix secondaries #340
Fix secondaries #340
Conversation
|
@kareltucek well, it didn't close UltimateHackingKeyboard/firmware#955. You might have fixed some parts of the postponer logic, and it feels like a number of things are working more reliably now. However, there's more: I've followed up in UltimateHackingKeyboard/firmware#955 with more test cases, and some more explanation when I experience this issue. |
|
Oh wait - was this not merged yet? Then I don't know how to test. Where would I be able to download a build with the fixes, and get it to run on the UHK? |
|
It's not merged yet. Please test https://github.com/UltimateHackingKeyboard/firmware-uhk80/actions/runs/11636720811 as soon as the build gets ready. |
|
OK, I installed that new build and while it fixed something that made problems with my HRM macros (I hadn't even reported it as it is difficult to describe in a simple test case and very similar to UltimateHackingKeyboard/firmware#955), the issues described in UltimateHackingKeyboard/firmware#955 still exist -- they haven't been resolved by this commit. So: this build is better, but does not fix everything with secondaries. I would still merge it to main as it seems the changes do solve some problems. |
Closes UltimateHackingKeyboard/firmware#955.
@mhantsch this fixes two serious problems of postponer, however, I am not at all sure that I have not missed some other major postponer's issues - the postponer code in combination with the event driven refactor is hellishly complex, and while writing it, I was focused on basic functionality.
The bottom line is that I will be glad if you try to test postponer-related features and report any other issues.
(Note that this PR goes against master-paired, which means that you will need to either pair your keyboard with the pair.sh script, or wait for Agent support.)