Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 add support for the more used job board #42

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

UmairJibran
Copy link
Owner

closes #3
ultimately also
closes #4
closes #5
closes #6
closes #7
closes #10

@UmairJibran UmairJibran requested a review from Copilot December 8, 2024 08:44
@UmairJibran UmairJibran self-assigned this Dec 8, 2024
@UmairJibran UmairJibran linked an issue Dec 8, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 suggestion.

Files not reviewed (1)
  • python/.env.example: Language not supported
Comments skipped due to low confidence (1)

python/main.py:41

  • [nitpick] The api_response_structure is a JSON string inside another JSON object. This should be clarified to avoid confusion.
"api_response_structure": json.dumps({"job_title":"<title of the job>","job_description":"<complete description of the job>","company":"<name of the company>","skills_list":["<skills required for this job>"]})

python/main.py Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@UmairJibran UmairJibran requested a review from Copilot December 8, 2024 08:47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • python/.env.example: Language not supported
Comments skipped due to low confidence (1)

python/app.py:44

  • [nitpick] The error message could be more specific, mentioning the reason for the failure, such as missing API key or unsupported job board.
return "Job details could not be fetched. Please try again."
@UmairJibran UmairJibran merged commit 20cf333 into master Dec 8, 2024
1 check passed
@UmairJibran UmairJibran deleted the 3-add-support-for-the-more-used-job-board branch December 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xing Glassdoor Indeed LinkedIn Add Support for the more used job board
1 participant