Added an alternative implementation using a wrapper <span> (instead of absolute positioning, see issue #4)#5
Open
jkphl wants to merge 2 commits intoUmbraEngineering:masterfrom
jkphl:master
Open
Added an alternative implementation using a wrapper <span> (instead of absolute positioning, see issue #4)#5jkphl wants to merge 2 commits intoUmbraEngineering:masterfrom jkphl:master
jkphl wants to merge 2 commits intoUmbraEngineering:masterfrom
jkphl:master
Conversation
absolute positioning, see issue #4)
Member
|
Great, I'll take a look. |
Member
|
Sorry for taking so long to back on this. Can you update the |
Contributor
Author
|
Sure, I will take care of that tomorrow! (~12 p.m. over here right now) |
Contributor
Author
|
Hi James, I added a readme section and demo for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi James,
as discussed earlier (see issue #4) I added a new implementation using an additional
<span>element to avoid absolute positioning on the page. Unfortunately, I don't have the time right now to really test it with a lot of different clients, but it works in IE9 (which is my primary target platform) and should work in most others as well, as the differences to your originalspanimplementation are only marginal.Let me know if it works for you as well!
Cheers,
Joschi