-
Notifications
You must be signed in to change notification settings - Fork 91
Link styling tweaks #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link styling tweaks #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think adding the dotted underlines with JavaScript is a good move. It adds overhead on every page load, linear in the number of links (which is most of the content), and the resulting separation is still pretty easy to miss IMO. The more scalable solution would be to try and phrase things in such a way that you don't get runs of links (like the original |transitive| |well-founded relation|
got reworded into |relation| that is |transitive| and |well-founded|
).
I have to disagree that it's not an improvement, but let's not fight about this now. The issue is very minor anyways, and I've reverted the relevant changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this one slipped through the cracks
There's really only Firefox 115 ESR which doesn't support :has, and it itself is only supported on Windows 8 and macOS Mojave, until March 2026
bb36f9c
to
eeecd48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with these changes, but let me know if you manage to reproduce the external link indicators showing up in your Firefox. Otherwise feel free to merge it
I'll test it right now |
Nope, they're gone! |
## Summary - [X] ~Add dotted underlines under links that are adjacent making it possible to tell them apart, e.g.:   The styling does not apply to code, or concept paragraph symbols, and it only applies to links with another link directly adjacent to it.~ - [X] Don't display underline on hover in code. New:  vs old:  - [X] Add external link indicator, e.g., the symbol after the first link below <img width="506" height="257" alt="image" src="https://github.com/user-attachments/assets/6a19d2ca-c99e-44a8-be30-245fc1159589" /> --------- Co-authored-by: VojtechStep <vojtechstepancik@outlook.com>
Summary
Add dotted underlines under links that are adjacent making it possible to tell them apart, e.g.:


The styling does not apply to code, or concept paragraph symbols, and it only applies to links with another link directly adjacent to it.
vs old: