Skip to content

Completed Assignment (woobr005) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Completed Assignment (woobr005) #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43990bc
Fixed Basket Authorisation
woobr005 Oct 27, 2024
4d3ebfc
Added some security tests
woobr005 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,39 @@ jobs:
name: api-test-lcov
path: |
api-lcov.info
security-api-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@develop

- name: Install HTTPie
run: |
sudo apt-get update
sudo apt-get install -y httpie

- name: Run the Web App
run: |
npm run serve

- name: Test for authentication requirement on POST for basket
run: |
http POST http://localhost:3000/rest/basket
--expect '401 Unauthorized'

- name: Test for authentication requirement on PUT for basket
run: |
http PUT http://localhost:3000/rest/basket/4
--expect '401 Unauthorized'

- name: Test for authentication requirement on GET for basket
run: |
http GET http://localhost:3000/rest/basket/4
--expect '401 Unauthorized'

- name: Test for authentication requirement on POST for feedback
run: |
http POST http://localhost:3000/rest/feedbacks
--expect '401 Unauthorized'
coverage-report:
needs: [test, api-test]
runs-on: ubuntu-latest
Expand Down
6 changes: 6 additions & 0 deletions routes/basket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ module.exports = function retrieveBasket () {
const user = security.authenticatedUsers.from(req)
return user && id && id !== 'undefined' && id !== 'null' && id !== 'NaN' && user.bid && user.bid != id // eslint-disable-line eqeqeq
})
const user = security.authenticatedUsers.from(req)
// check if the correct user is making the request
if (user && id && id !== 'undefined' && id !== 'null' && id !== 'NaN' && user.bid && user.bid != id) { // eslint-disable-line eqeqeq
res.status(403).send({ error: 'wrong user' })
return
}
if (basket?.Products && basket.Products.length > 0) {
for (let i = 0; i < basket.Products.length; i++) {
basket.Products[i].name = req.__(basket.Products[i].name)
Expand Down