New test cases added #5
Conversation
|
Hi @harinandana02 . Thanks for the PR. Currently the test cases are failing. Could you investigate what's going wrong ? Also, it would be nice if you could provide a single commit (collapsing all your commits into 1) and a small description of what this PR does. |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 59.37% 60.93% +1.56%
==========================================
Files 3 3
Lines 128 128
==========================================
+ Hits 76 78 +2
+ Misses 52 50 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks for the PR. At the moment commenting out the the functionality in the OAttributeGraph constructor kind-of kills the purpose of the PR. If you would like, you could try again with the additional functionality integrated. Feel free to test it first locally!
| @@ -6,11 +6,13 @@ version = "0.2.0" | |||
| [deps] | |||
| DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae" | |||
| Graphs = "86223c79-3864-5bf0-83f7-82e725a168b6" | |||
| Revise = "295af30f-e4ad-537b-8983-00126c2a3abe" | |||
There was a problem hiding this comment.
please do not introduce unneeded dependencies. Revise and Run are both very useful packages but not inseparable from this package. Users can have them if they wish already installed in the general environment or whatever.
| DocStringExtensions = "0.9" | ||
| Graphs = "1" | ||
| julia = "1.8" |
There was a problem hiding this comment.
please avoid unneeded modifications like this
test/opinionatedtest.jl
Outdated
|
|
||
| # unit testing | ||
| #simple test case | ||
| @test true |
There was a problem hiding this comment.
this @test true is totally unneeded. However I am having trouble to release what is the purpose of this testing file. It looks more or less like a repetition from the ./test/attributes.jl (?)
|
Outdated pull request. |
Added several test cases ( opinionatedtest.jl file)