fix up some minor ncss issues #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haileyajohnson
commented
Jul 11, 2023
haileyajohnson
commented
- don't throw if a variable doesn't intersect the requested time
- refactor request too large exception so the TDS can recognize it more explicitly
|
I've tested this manually but I could probably add a unit test |
tdrwenski
approved these changes
Jul 12, 2023
cdm/core/src/main/java/ucar/nc2/ft2/coverage/CoordAxisHelper.java
Outdated
Show resolved
Hide resolved
| @@ -204,13 +206,14 @@ else if (upperIndex > axis.getCoordEdgeLast()) | |||
| // LOOK not using bounded | |||
There was a problem hiding this comment.
maybe this comment can go now that we are using bounded
Suggested change
| // LOOK not using bounded |
haileyajohnson
force-pushed
the
ncss-errors
branch
from
430fd5c
to
7714c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.