-
Notifications
You must be signed in to change notification settings - Fork 14
Add borders between table rows #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test results 10 files 1 160 suites 38m 0s ⏱️ Results for commit 291c681. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1284 +/- ##
=======================================
Coverage 77.74% 77.74%
=======================================
Files 141 141
Lines 5662 5662
=======================================
Hits 4402 4402
Misses 1260 1260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9c9e34e
to
cd838d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
|
Yes looks very similar to the lines shown in the old argus deployment Question is how would this look on a big screen with the appropriate zoom. I think it would be good if we had another meeting with the service center guys where they test it themselves on the big screen and give feedback |
Good point! I will merge it for now and make a new PR if they think it is too subtle on the big screen |
The users in the service center also would prefer continuous line for the borders, see #1285 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing on different themes: Looks good on Argus theme (against the light blue background), difficult to see on Light theme (white background) and pretty much invisible on dark theme, so this is something that must be configurable per theme
Good catch! |
Scope and purpose
Fixes #1253
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.