Skip to content

Add more documentation for api endpoint GET requests #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #752.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (cb31c91) to head (fc385ff).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          73       73           
  Lines        3608     3608           
=======================================
  Hits         2866     2866           
  Misses        742      742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 12, 2024

Test results

       7 files     511 suites   19m 35s ⏱️
   408 tests    407 ✔️ 1 💤 0
2 856 runs  2 849 ✔️ 7 💤 0

Results for commit fc385ff.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file would not be necessary if we settle on #648.

@johannaengland
Copy link
Contributor Author

This file would not be necessary if we settle on #648.

Yes, but until that is merged we can have this for now? Doesn't hurt

@hmpf hmpf self-requested a review April 15, 2024 10:04
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it off the board.

@johannaengland johannaengland force-pushed the docs/add-example-response-for-get branch from 44ad135 to fc385ff Compare April 15, 2024 10:08
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johannaengland johannaengland merged commit e0a66ca into Uninett:master Apr 15, 2024
@johannaengland johannaengland deleted the docs/add-example-response-for-get branch April 15, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more documentation for api endpoint GET requests
3 participants