Uncrispify DetentionProfileForm

[stveit]

Fixes #3174

http://localhost/arnold/predefined/add

or http://localhost/arnold/predefined/edit/

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	992		0	11.22s
✅ PYTHON	ruff	987		0	0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[github-actions]

Test results

    9 files      9 suites   8m 21s ⏱️
2 138 tests 2 138 ✅ 0 💤 0 ❌
4 015 runs  4 015 ✅ 0 💤 0 ❌

Results for commit df681f4.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.40%. Comparing base (9c879be) to head (df681f4).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3196   +/-   ##
=======================================
  Coverage   60.39%   60.40%           
=======================================
  Files         605      605           
  Lines       43703    43698    -5     
  Branches       48       48           
=======================================
+ Hits        26394    26395    +1     
+ Misses      17297    17291    -6     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johannaengland]

The HTML that is generated does look a bit different, just as an example this is the difference of the active checkbox:

Previous

<div id="div_id_active" class="ctrlHolder">
    <label for="id_active">
        Active
        <input type="checkbox" name="active" class="input-align" id="id_active">
    </label>
</div>

Now

<div id="div_id_active" class="ctrlHolder input-align">
    <label for="id_active">
        Active
       <input type="checkbox" name="active" id="id_active">
    </label>
</div>

But since it does not make a difference on how it actually looks I am happy with it

[stveit]

The HTML that is generated does look a bit different, just as an example this is the difference of the active checkbox:

Previous

<div id="div_id_active" class="ctrlHolder">
    <label for="id_active">
        Active
        <input type="checkbox" name="active" class="input-align" id="id_active">
    </label>
</div>

Now

<div id="div_id_active" class="ctrlHolder input-align">
    <label for="id_active">
        Active
       <input type="checkbox" name="active" id="id_active">
    </label>
</div>

But since it does not make a difference on how it actually looks I am happy with it

Well thats annoying, but I think I know the solution. Sadly the solution will probably invalidate #3199 :P

[johannaengland]

I actually don't know if these css classes are actually necessary, because if I remove them it still looks the same to me
@podliashanyk what do you think?

[johannaengland]

Alright, after a little deep dive I believe we don't need the css class input-align at all, because it only does anything in combination with the class checkboxinput and that one has been removed from the template for many many years - actually when we went over to crispy forms - the commit removing checkboxinput is this one: 43f861e6016fd051267d8450e53

So #3199 was not necessary in the end I believe and we can simply remove these css classes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud