Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-in-one create collection #971

Merged
merged 13 commits into from
Aug 16, 2023
Merged

Conversation

fairax
Copy link
Contributor

@fairax fairax commented Aug 14, 2023

No description provided.

@fairax fairax self-assigned this Aug 14, 2023
Cargo.toml Outdated Show resolved Hide resolved
pallets/common/src/eth.rs Outdated Show resolved Hide resolved
pallets/common/src/eth.rs Show resolved Hide resolved
pallets/unique/src/eth/mod.rs Show resolved Hide resolved
pallets/unique/src/eth/mod.rs Show resolved Hide resolved
pallets/unique/src/eth/mod.rs Outdated Show resolved Hide resolved
Base automatically changed from feature/update-polkadot-v0.9.43 to develop August 14, 2023 13:11
@CertainLach
Copy link
Member

Дедуплицировал структуру CollectionFlags, т.к она была одинаковой в двух модулях
Запретил использовать флаги кроме erc721metadata
Исправил CollectionMode: ты переставил #[default], однако не поменял порядок полей, при неуказании типа коллекции в evm она всё так же создавалась fungible, т.к 0 == первое поле == Fungible
Временно закомментировал код создания коллекций, поскольку нужно пересмотреть реализацию спеки в evm-coder

@CertainLach CertainLach merged commit 20ac01d into develop Aug 16, 2023
7 of 15 checks passed
@CertainLach CertainLach deleted the feature/all-in-one-create-collection branch August 16, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants