store boolean instead of address #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
requested changes
Mar 4, 2024
hensha256
reviewed
Mar 5, 2024
hensha256
reviewed
Mar 5, 2024
hensha256
reviewed
Mar 5, 2024
Closed
dianakocsis
force-pushed
the
store-boolean-for-lock
branch
from
bc5c2f1 to
e3b5a9e
Compare
snreynolds
previously approved these changes
Mar 11, 2024
src/test/PoolNestedActionsTest.sol
Outdated
| (address locker) = manager.getLocker(); | ||
| assertTrue(locker != address(this), "Locker wrong"); | ||
|
|
||
| function _swap(address locker) internal { |
There was a problem hiding this comment.
super nit but this really is now the caller right? Seems like we renamed (which I like better!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
store boolean for lock #487
Description of changes
Removes storing the locker address and now stores a boolean instead