Enable via IR compilation / memory safe issue fix #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
… that the gas overhead subtraction in the gas snapshot library causes an underflow
snreynolds
reviewed
May 24, 2024
gretzke
changed the title
hensha256
reviewed
May 24, 2024
gretzke
force-pushed
the
memory-safe-assembly
branch
from
80fa48e to
daf4e2e
Compare
gretzke
force-pushed
the
memory-safe-assembly
branch
from
daf4e2e to
e088b4c
Compare
hensha256
reviewed
May 28, 2024
| @@ -1,8 +1,8 @@ | |||
| [profile.default] | |||
| optimizer_runs = 800 | |||
| via_ir = false | |||
| optimizer_runs = 44444444 | |||
hensha256
reviewed
May 28, 2024
| 1630 |
hensha256
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling via ir compilation fails due to memory safeness issues, unless every assembly block from this PR are annotated as
memory-safe. Once compilation succeeds two tests fail with a panic error (over- or underflow) that do not fail when compiling without ir.