Add modifyLiquidity script and call with ffi to check to test for accuracy #702
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Forge code coverage:
|
* bundle typescript into javascript files * remove unused imports * adjust just file
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore npm/esbuild@0.21.3 |
Related Issue
Which issue does this pull request resolve?
Testing function accuracy (modifyLiquidity)
Description of changes
Sets up ffi infra for modifyLiquidity - should be able to use the same getModifyLiquidityResult.ts for additional add/remove tests.
TODO (Will do in future PR to keep small)
Check the fee returns.
Check removeLiquidity.
Check multiple add or removes.
Check for more granular accuracy - can we get less than ONE_PIP error?
Fix CI for the new v3-sdk dependency.
Add docs to README.
To run tests now:
install just
cd test/js-scriptsnpm iThen run from main directory:
foundryupjust test