Optimize CurrencyLibrary.transfer
#717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor ETH transfer in `CurrencyLibrary` The ETH transfer process in the Currency.sol file is now refactored using memory-safe assembly code. A new approach has been introduced to handle the transfer failure, instead of just setting the `success` variable value, the process now directly reverts with a `NativeTransferFailed` error. This ensures a more robust and reliable transfer process. * Refactor ERC20 transfer error handling The code has been streamlined by removing the `success` variable used in the ERC20 transfer method, and directly integrating the error handling into the function call. This change helps minimize unnecessary variable usage and allows more immediate error feedback, improving the program's efficiency and clarity. * Use Solady `SafeTransferLib.safeTransfer` --------- Co-authored-by: Daniel Gretzke <daniel@gretzke.de>
|
Forge code coverage:
|
hensha256
reviewed
May 26, 2024
hensha256
reviewed
May 26, 2024
hensha256
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #710