Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm deploy #941

Merged
merged 6 commits into from
Feb 6, 2025
Merged

npm deploy #941

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62d9aff
npm deploy
mr-uniswap Feb 6, 2025
5a6069e
Update deploy.yaml
mr-uniswap Feb 6, 2025
1320634
Update deploy.yaml
mr-uniswap Feb 6, 2025
a8ed490
Update deploy.yaml
mr-uniswap Feb 6, 2025
9f07e3e
Update deploy.yaml
mr-uniswap Feb 6, 2025
af7c077
Update deploy.yaml
mr-uniswap Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ jobs:
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744

- name: Setup Node
uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7
uses: actions/setup-node@v4.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you using a tag instead of a commit now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actions/setup-node is a github first party action, so we can trust it, and it never needed to be on a commit hash

with:
node-version: 18
node-version: "20.x"
registry-url: "https://registry.npmjs.org"
scope: "@uniswap"

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
Expand All @@ -49,7 +50,8 @@ jobs:

- name: Release
env:
NPM_CONFIG_USERCONFIG: /dev/null
NODE_AUTH_TOKEN: ${{ env.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm publish
run: |
npm set "//registry.npmjs.org/:_authToken" ${{ env.NPM_TOKEN }}
npm publish --provenance --access public
Loading