Develop

[PooyaFekri]

Summary by Sourcery

Fix indexing issues in the is_following and be_followed_by methods to ensure correct retrieval of follower and following status.

Bug Fixes:

• Fix incorrect indexing in the methods is_following and be_followed_by to correctly access the follower and following status.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the is_following and be_followed_by methods in the core/thirdpartyapp/farcaster.py file. The changes involve accessing specific keys from the dictionaries returned by the _get_followers_status and _get_follow_status methods.

File-Level Changes

Change	Details	Files
Updated return statements in is_following and be_followed_by methods to access specific dictionary keys	Modified is_following method to return self._get_followers_status(follower_fid, fid)[fid] instead of just self._get_followers_status(follower_fid, fid) Modified be_followed_by method to return self._get_follow_status(fid, following_fid)[following_fid] instead of just self._get_follow_status(fid, following_fid)	core/thirdpartyapp/farcaster.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @PooyaFekri - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (bug_risk): Potential KeyError risk in dictionary access

The changes to is_following and be_followed_by methods now assume that _get_followers_status and _get_follow_status return dictionaries with specific keys. This could lead to KeyErrors if the expected keys are not present. Consider using the dict.get() method with a default value or checking for the key's existence before accessing it. Also, ensure that all code relying on these methods is updated to handle the new return type.

Suggested change

	"""
	try:
	following_fid = self._get_profile(address)["fid"]
	return self._get_follow_status(fid, following_fid)
	return self._get_follow_status(fid, following_fid)[following_fid]
	return self._get_followers_status(follower_fid, fid).get(fid, False)
	except (
	RequestException,
	IndexError,
	"""
	try:
	following_fid = self._get_profile(address)["fid"]
	return self._get_follow_status(fid, following_fid).get(following_fid, False)