[feature/multi2delaf] Add the transcoding function #125
Conversation
Add missing parenthesis around variable BIN_DIR when it is used.
src/Multi2Delaf.h
Outdated
| Multi2Delaf(const char* config_filename); | ||
| ~Multi2Delaf(); | ||
| // Not copyable or movable | ||
| Multi2Delaf(const Multi2Delaf&) UNITEX_EQ_DELETE; |
There was a problem hiding this comment.
As suggestion, if you use:
UNITEX_DISALLOW_COPY_AND_ASSIGN(Multi2Delaf);
This will expand to:
Multi2Delaf(const Multi2Delaf&) UNITEX_EQ_DELETE;
void operator=(const Multi2Delaf&) UNITEX_EQ_DELETE;
src/Fst2List.cpp
Outdated
| {NULL,no_argument_TS,NULL,0} | ||
| }; | ||
|
|
||
| int main_Fst2List(int argc, char* const argv[]) { | ||
| char* ofilename = NULL; | ||
| char morpho_dic[1025] = ""; | ||
| char *config_file_name = NULL; |
There was a problem hiding this comment.
char* config_file_name = NULL;
instead of
char *config_file_name = NULL;
src/Fst2List.cpp
Outdated
| @@ -295,6 +299,10 @@ class CFstApp { | |||
| bool isMdg; // true if the graph is a morphological dictionary-graph | |||
| struct hash_table* path_to_stop; /* a hash table to know all the Fst2Tag whose path exploration must be interrupted */ | |||
| struct hash_table* dela_entries; /* a hash table to get the dela_entries of created boxes when lexical masks are processed */ | |||
| bool compileToDelaf = false; | |||
| Multi2Delaf *multi2Delaf = NULL; | |||
There was a problem hiding this comment.
Multi2Delaf* multi2Delaf = NULL;
|
Please also check for compilation errors on Travis : https://app.travis-ci.com/github/UnitexGramLab/unitex-core/builds/254307384#L990 |
|
As appveyor shows some linking errors (https://ci.appveyor.com/project/martinec/unitex-core/builds/44442271#L1729), in order to compile with VS, if you introduce new |
|
I will continue the review once the code can be built without issues. Thank you for your commitment. |
Description
Add a function to transcode the multidelaf string into a delaf-format tag.
Motivation and Context
[issue #51] Generate dictionaries based on morphological dictionary-graphs
specif-multi-to-delaf.pdf
Type of files
bin: Binary filesci: Continuous integration filesdoc: Documentation filesLevel of change
break: Breaking changeexp: Experimental changetmp: Temporal changemajor: Major changeminor: Minor changerevert: Revert a commit changesec: Vulnerability-related changeType of change
deprecat: Deprecation of a once-stable featureenhance: Enhancement in existing functionalityfix: Bug fixfeature: New featurehotfix: Hotfix for bugsrefactor: Improve coding style, commentsremove: Remove a featureChecklist: