Disable spot light's shadow pancaking in Urp. #8081
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
When a Spot Light casts shadows from a large triangle, shadow splitting can occur. This issue arises because the Shadow Pancaking, used in the vertex shader to optimize the light range for directional lights, cannot handle the rendering of large triangles correctly. However, most Spot Lights have an acceptable effective range. Therefore, it is desirable to add a toggle to disable Shadow Pancaking for Spot Lights.
issue:
fixed:
Testing status
A simple test scene was used and tested on PC with DirectX11 and on Android with GLES (without Reverse Z).