Internal/2022.3/staging #8099
Open
Internal/2022.3/staging #8099
+1,173
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om Function node's body field This PR fixes https://jira.unity3d.com/browse/UUM-76270. The Custom Function node's body field was difficult to use due to a combination of broken sizing and a lack of scrollbars. This fix prevents the body field from growing beyond the inspector width, and enables horizontal/vertical scrollbars. 
JIRA: https://jira.unity3d.com/browse/UUM-76198 Selecting the Context Block no longer activates the delete button.  
…ct feature UUM-76307 fix camera offset in the UI editor for the RenderObject feature UUM-76307
Jira: UUM-76346 Steps to reproduce: 1. Create a new HDRP project 2. Observe Console Actual results: Errors are thrown to the console Expected results: Console does not contain VFX Graph errors Reproducible with versions: 2022.3.39f1 Not reproducible with versions: 6000.0.12f1
…a wasn't updated properly for Asset Bundles (UUM-52890) Fixes UUM-52890
This PR fixes an issue where some leftover shadow-rendering uniforms aren't properly cleared when using the `Unlit Draw Mode` in the scene-view, leading to some visible artifacts when sampling the empty shadow-map set for this mode.
… cbuffer Shader Graph allows to declare properties in a global context. These properties can be set from script, globally to all shaders at the same time. (see [Shader.SetGlobalVector](https://docs.unity3d.com/ScriptReference/Shader.SetGlobalVector.html for instance)). These global properties work fine when used with a regular ShaderGraph material, but not with VFX outputs that use ShaderGraph. The reason is that we were grouping them in a structure with the other exposed properties, when these should be read directly from the constant buffer. Just changing the declaration in the shader makes it work fine.
…erial upgrader Fixes https://jira.unity3d.com/browse/UUM-78379. LOD Cross-fade is a per-material keyword in BiRP, but a pipeline-wide setting in URP. Therefore, the BiRP -> URP upgrader should omit this keyword from the upgraded material. This PR adds this logic to the upgrader.
… renderContext s… This is a manual backport of https://github.cds.internal.unity3d.com/unity/unity/pull/52682. There was a small merge conflict because the `EndCameraRendering()` callback is called inside an `if` condition in Unity 6.0, but there's no such condition in 2022.3. The intent of the original PR is to move the callback down, so that it is called after the render context is submitted. I have retained the spirit of that change in this port.
…ing high contrasted IBL This is a backport of https://github.cds.internal.unity3d.com/unity/unity/pull/44940
… version upgrade. This PR is intended to remove the VCS local checkout (due to `AssetDatabase.MakeEditable`) that happened on any reimport of SG assets. Jira: https://jira.unity3d.com/browse/UUM-17912
…e rendering. This PR aims to fix scene-view wireframe rendering issues when using forward/forward+ and depth-priming together. This bug was caused by depth-priming forcing the depth-test comparison function to `Equal` (instead of `LEqual` of the original wireframe-rendering shader) for opaque-rendering ([here](https://github.cds.internal.unity3d.com/unity/unity/blob/833b9fd62c679e02f6be2dc94d6150525ce88553/Packages/com.unity.render-pipelines.universal/Runtime/Passes/DrawObjectsPass.cs#L218-L223)), assuming that valid depth-values would have been rendered beforehand to the bound depth-attachment. This is not the case for wireframe rendering, and thus, nothing renders. Jira: https://jira.unity3d.com/browse/UUM-74999
…uild platforms are selected. This PR fixes an issue in URP when selecting Switch or Android build target were forcing the camera depth render target to be reallocated every frame. `UniversalRenderPipelineCore.CreateRenderTextureDescriptor` by default sets depth buffer 32 bit format, however in `UniversalRenderer.CreateCameraRenderTarget` the descriptor depth buffer format is overridden to a 24 bit format when Switch or Android build targets are selected triggering depth buffer re-allocation. The change to 24 bit format was implemented in https://github.cds.internal.unity3d.com/unity/unity/pull/15935 to solve crashes and performance issues on Android, but is not necessary when running in the Editor where instead it causes unnecessary depth buffer reallocations, leading to memory leaks under certain circumstances.
JIRA: https://jira.unity3d.com/browse/UUM-76242 An issue occurred because the API connected via Reflection was changed, causing the function to be undetectable. The code has been updated to align with the new API, and a unit test has been added to prevent future issues Before  After 
…rrect shader code for 16-bit half precision. JIRA: [UUM-72722](https://jira.unity3d.com/browse/UUM-72722) This PR fixes a bug that Normal From Height node in a shader graph might return an invalid value when using 16-bit half precision. <table><thead> <tr> <th><img src="https://media.github.cds.internal.unity3d.com/user/7006/files/2082dd6b-3b91-4f48-9c05-f440ccfea156" /></th> <th><img src="https://media.github.cds.internal.unity3d.com/user/7006/files/b31992b2-c6ae-45c9-989e-bacd86ac97c3" /></th> </tr></thead> <tbody> <tr> <td>before</td> <td>after</td> </tr> </tbody> </table>
…backup' errors on entering Playmode with shader graphs open. JIRA: [UUM-71052](https://jira.unity3d.com/browse/UUM-71052) This PR fixes 'Objects are trying to be loaded during a domain backup' errors due to invalid serialization within SerializableTexture. One possible case is, as reported in JIRA, entering Play mode with PhysicalHair_Cards shadergraph from HDRP material sample open.
…Name. Jira: https://jira.unity3d.com/browse/UUM-76081 Added a displayName to AbstractMaterialNode to use when displaying it in the Graph Inspector. displayName defaults to name, and is overridden by BlockNode to create it using shaderStage and displayName.  The changed name looks like this: <table> <tr><th>Before</th><th>After</th></tr> <tr><td>VertexDescription.Position Node</td><td>Vertex Position Node</td></tr> <tr><td>VertexDescription.Normal Node</td><td>Vertex Normal Node</td></tr> <tr><td>VertexDescription.Tangent Node</td><td>Vertex Tangent Node</td></tr> <tr><td>SurfaceDescription.BaseColor Node</td><td>Fragment Base Color Node</td></tr> <tr><td>SurfaceDescription.NormalTS Node</td><td>Fragment Normal (Tangent Space) Node</td></tr> <tr><td>SurfaceDescription.Metalilc Node</td><td>Fragment Metallic Node</td></tr> <tr><td>SurfaceDescription.Smoothness Node</td><td>Fragment Smoothness Node</td></tr> <tr><td>SurfaceDescription.Emission Node</td><td>Fragment Emissiton Node</td></tr> <tr><td>SurfaceDescription.Occlusion Node</td><td>Fragment Ambient Occlusion Node</td></tr> </table>
…nfinity This PR fixes a freeze when the `Camera farClip` is set to `Infinity`. Basically, the Light Forward+ algorithm was freezing the editor because the farClip becomes negative, which is not a valid scenario, so most of the calculations are not ending (freeze). Clamping it to a minimum value of 0 fixes the freeze without any drawback.
…d boundaries. Jira: [UUM-70628](https://jira.unity3d.com/browse/UUM-70628) Parent PR: [#48000](https://github.cds.internal.unity3d.com/unity/unity/pull/48000) As reported in JIRA, the sun flicker problem occurs when the directional light is close to cloud boundaries. This can only be reproduced if `perceptual blending` is enabled on volumetric clouds. The transmittance of each pixel changes every frame due to ray marching noise and temporal reprojection. When perceptual blending is enabled, it divides the transmittance by the current luminance of the target pixel, so it reduces the RGB value dramatically when the luminance is really high.  When the `perceptual blending` is disabled, we simply use the original input transmittance, so that neighboring pixels have slightly different values. However, we reduce the transmittance by luminance when `perceptual blending` is enabled. This causes a huge pixel value change for neighboring pixels at the cloud boundaries, so the sun flickers.  By softening the transmittance attenuation curve with a `pow(transmittance, 6)` clamp, we can prevent sun flicker and slightly improve the perceptual blending where the sun is behind the clouds.  | Before | After | | -- | -- | | ||
|
It appears that you made a non-draft PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.