Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dedicated Game Server Sample - scenes and domain not reloaded [MTT-8055] #276

Open
wants to merge 1 commit into
base: feat/dedicated-game-server-sample/upgrade-to-multiplayer-services-sdk
Choose a base branch
from

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Mar 7, 2025

Description

PR to simply add to modify the project's editor settings such that Domain Reload is disabled.

Issue Number(s)

MTT-8055

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • [ N/A ] Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez changed the title feat: Dedicated Game Server Sample - scenes and domain not reloaded feat: Dedicated Game Server Sample - scenes and domain not reloaded [MTT-8055] Mar 7, 2025
@fernando-cortez fernando-cortez marked this pull request as ready for review March 11, 2025 23:39
@fernando-cortez fernando-cortez requested a review from a team as a code owner March 11, 2025 23:39
@RikuTheFuffs
Copy link
Contributor

@fernando-cortez I don't see any change to classes that have static fields (I.E: ApplicationEntryPoint.cs , ServerPlayerSpawnPoints.cs and UnityServiceAuthenticator.cs). When domain reloads is disabled, static fields do not automatically clean up properly across Play runs.
Did you test running the game multiple times from the editor using different roles? (I.E: running as a server, then as a client)
If yes, does everything reset properly at the beginning of each run?

@fernando-cortez
Copy link
Collaborator Author

@fernando-cortez I don't see any change to classes that have static fields (I.E: ApplicationEntryPoint.cs , ServerPlayerSpawnPoints.cs and UnityServiceAuthenticator.cs). When domain reloads is disabled, static fields do not automatically clean up properly across Play runs. Did you test running the game multiple times from the editor using different roles? (I.E: running as a server, then as a client) If yes, does everything reset properly at the beginning of each run?

Yup exactly this. I tested all the scenarios, and tested their reconnection flows too. No errors, so it doesn't seem necessary to clean up any static fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants