WIP: Implement symbolication precognition #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvuk
force-pushed
the
precog
branch
2 times, most recently
from
3aa3054
to
7ac737f
Compare
mstange
reviewed
May 15, 2024
samply/src/shared/symbol_precog.rs
Outdated
|
|
||
| #[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq, Hash)] | ||
| //struct StringTableIndex(usize); | ||
| struct StringTableIndex(String); |
samply/src/shared/symbol_precog.rs
Outdated
Comment on lines
221
to
222
| unsafe impl Sync for PrecogSymbolInfo {} | ||
| unsafe impl Send for PrecogSymbolInfo {} |
wholesym/src/helper.rs
Outdated
| &self, | ||
| info: &LibraryInfo, | ||
| ) -> Option<(Self::FL, Box<dyn SymbolMapTrait + Send + Sync>)> { | ||
| if let Some(precog_helper) = self.config.precog_helper.as_ref() { |
There was a problem hiding this comment.
I would just have a HashMap<(String, DebugId), Arc<dyn SymbolMapTrait + Send + Sync>> stored inside the helper. And then you would add those with wholesym::SymbolManager::add_precog_symbol_map similarly to how we add known libs. This wouldn't require an extra trait.
samply/Cargo.toml
Outdated
| @@ -11,6 +11,7 @@ readme = "README.md" | |||
|
|
|||
| [dependencies] | |||
|
|
|||
| samply-symbols = { version = "0.22.0", path = "../samply-symbols" } | |||
There was a problem hiding this comment.
This isn't needed, you can just use wholesym::samply_symbols in the code - it won't make a difference but I think it's good practice to use the re-export in order to avoid mixing versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP horrible, but maybe not totally horrible?
Notes:
GlobalLibTablegained a parallelused_rvasarray because I didn't want to modify theLibraryInfotype (lots of cascading effects)Clonefromwholesym::SymbolManagerConfig. Keeping it was causing me all sorts of pain with the dyn trait object.&'staticfor thePrecogHelperis also a hack, but it might be one that's in the "whatever" categoryIf there is a precog helper, this PR searches only it for symbols, for testing(removed in followup commit but can be uncommented)