Libr311 Accessibility - Issue #25 #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When verifying focus traversal for Map View, it was apparent the Center Map option wasn't focusable Signed-off-by: Tim Dalton <daltont@objectcomputing.com>
daltontf
commented
Dec 17, 2025
| div.style.display = 'flex'; | ||
| div.style.justifyContent = 'center'; | ||
| div.style.alignItems = 'center'; | ||
| const control = L.DomUtil.create('a'); |
Contributor
Author
There was a problem hiding this comment.
I rename the field in case for some reason we make it a button which also focusable.
There was a problem hiding this comment.
Since the href of this "a" element is just set to "#" (not navigating to a new URL), it seems like this really should be a "button" element instead of an "a" element.
…ocus wasn't highlighting like the zoom buttons. Signed-off-by: Tim Dalton <daltont@objectcomputing.com>
…ocus wasn't highlighting like the zoom buttons. Signed-off-by: Tim Dalton <daltont@objectcomputing.com>
daltontf
commented
Dec 17, 2025
| control.appendChild(img); | ||
| control.setAttribute('role', 'button'); | ||
| control.setAttribute('title', 'Center Map'); | ||
| control.setAttribute('aria-label', 'Center Map'); |
Contributor
Author
There was a problem hiding this comment.
"Center Map" being the same prevents NDVA and Narrator from repeating.
daltontf
commented
Dec 17, 2025
| } | ||
|
|
||
| control.addEventListener('mouseenter', highlight); | ||
| control.addEventListener('focus', highlight); |
Contributor
Author
There was a problem hiding this comment.
Handle focus like the Zoom In and Zoom out buttons
Signed-off-by: Tim Dalton <daltont@objectcomputing.com>
mvolkmann
reviewed
Dec 18, 2025
| control.setAttribute('title', 'Center Map'); | ||
| control.setAttribute('aria-label', 'Center Map'); | ||
| control.href = '#'; | ||
| control.style.backgroundColor = '#fff'; |
There was a problem hiding this comment.
I wonder why all this styling was done in JavaScript instead of in a CSS file. It probably should be moved to CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When verifying focus traversal for Map View, it was apparent the Center Map option wasn't focusable