Libre 311 Accessibility Issue #35 #304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can navigate to "Logout" using the keyboard, but cannot select it. Signed-off-by: Tim Dalton <daltont@objectcomputing.com>
daltontf
commented
Dec 17, 2025
| <Avatar initials={$user?.username.charAt(0).toUpperCase()} /> | ||
| </button> | ||
| <Dropdown.Items slot="items"> | ||
| <Dropdown.Items.Item on:click={logout} label="Logout"></Dropdown.Items.Item> |
Contributor
Author
There was a problem hiding this comment.
ChatGPT had suggestions involving role, as, tabindex attributes, but they didn't work. This did.
mvolkmann
previously approved these changes
Dec 18, 2025
…ork. Signed-off-by: Tim Dalton <daltont@objectcomputing.com>
mvolkmann
reviewed
Dec 18, 2025
| goto('/'); | ||
| } | ||
| function logout_keydown(e: CustomEvent) { |
There was a problem hiding this comment.
It looks like the convention in this project is for method names to be camelCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can navigate to "Logout" using the keyboard, but cannot select it.