Removal suggestions #331
Open
Removal suggestions #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Elliott <elliottj@objectcomputing.com>
Signed-off-by: Jesse Elliott <elliottj@objectcomputing.com>
Signed-off-by: Jesse Elliott <elliottj@objectcomputing.com>
Signed-off-by: Jesse Elliott <elliottj@objectcomputing.com>
stanleykc
reviewed
Jan 15, 2026
stanleykc
reviewed
Jan 15, 2026
stanleykc
reviewed
Jan 15, 2026
Comment on lines
+36
to
+41
| setTimeout(() => { | ||
| handleClose(); | ||
| setTimeout(() => { | ||
| reset(); | ||
| }, 500); | ||
| }, 1500); |
Member
There was a problem hiding this comment.
There could be a potential leak here if the user closes the modal or navigates away prior to firing.
stanleykc
requested changes
Jan 15, 2026
Member
stanleykc
left a comment
stanleykc
left a comment
There was a problem hiding this comment.
Working with Claude, I found a few items that might improve the code. I think it works well, although the "Suggest Removal" link is not very obvious - it kind
Signed-off-by: Jesse Elliott <elliottj@objectcomputing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented service request removal suggestions.
Backend:
Frontend: