Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.8.0 with new Features, Bugfixes and Cherry picking from haleyjd and jdlrobson, activate Themes #30

Merged
merged 21 commits into from
May 5, 2024

Conversation

WikiMANNia
Copy link
Contributor

@WikiMANNia WikiMANNia commented May 3, 2024

Layout

  • Set a blank between icon and text

Cherry picking from haleyjd

commit 68094fd (haleyjd/monaco-port@68094fd)
Make contribute button into optional/configurable paypal and patreon …

commit 2a28088 (haleyjd/monaco-port@2a28088)
Auto overflow in std widget lists

commit 653d2b4 (haleyjd/monaco-port@653d2b4)
Handle IPv6 in monacoWidget.UserLink

Cherry picking from jdlrobson
commit 9435855 (jdlrobson@9435855)
Issues regarding to REL1_41

Code lifting

  • Avoid using global variables directly
  • use "MediaWiki\Config\GlobalVarConfig" instead of "global"
  • Modernise the hook architecture

Version 2.7.0 - Add a new hook

  • add new hook MonacoStaticboxEnd (this makes it possible inserting Donation buttons by Extensions)

Version 2.8.0 - Themes activated

  • add hook GetPreferences
  • add UserOptionsLookup
  • add i18n - Translations of the themes

global $wgUser is deprecated
avoid "$user->getOption()"
use SpecialPage::newSearchPage( $user )->getLocalURL()
$request->getVal( 'returntoquery' )
avoid automatic bool to array conversion
add sh.json
+i18n/sh.json
+ContentRightSidebar/i18n/sh.json
add &$html parameter to hooks
add new hook MonacoStaticboxEnd
use MediaWiki\HookContainer\HookContainer;
Set a blank between icon and text
commit 68094fd (haleyjd/monaco-port@68094fd)
Make contribute button into optional/configurable paypal and patreon …

commit 2a28088 (haleyjd/monaco-port@2a28088)
Auto overflow in std widget lists

commit 653d2b4 (haleyjd/monaco-port@653d2b4)
Handle IPv6 in monacoWidget.UserLink
use "MediaWiki\Config\GlobalVarConfig" instead of "global"
code embellishment
add hook GetPreferences
add UserOptionsLookup
add i18n - Translations of the themes
add hook GetPreferences
add UserOptionsLookup
add i18n - Translations of the themes
These files were added to the repository by mistake
@Universal-Omega
Copy link
Owner

How much of this is tested?

@WikiMANNia
Copy link
Contributor Author

It is tested with MediaWiki 1.41.1, 1.39.7 and 1.35.14.

Selection of themes are working now and the aditional Hook "MonacoStaticboxEnd" is used by the extenision [DonateButton] (https://www.mediawiki.org/wiki/Extension:DonateButton).

The "Cherry picking from haleyjd" is also tested.

public function onGetPreferences( $user, &$preferences) is basically taken from the extension [Theme] (https://www.mediawiki.org/wiki/Extension: Theme).

The rest is code lifting and some adaptations regarding to PHP 7 and PHP 8, avoiding warnings etc. No rocket science. ;-)

As you can see on our GitHub-Site, that we have already a bunch of little extensions for MediaWiki, including forks for HitCounters and MobileDetect.

@Universal-Omega Universal-Omega merged commit a1190db into Universal-Omega:master May 5, 2024
14 checks passed
@WikiMANNia
Copy link
Contributor Author

I prepared the commits for the REL1_35 branch overnight.

As I see, you have already approved the pull request.

I was about to delete my fork and start from scratch.

I was planning to make the commits a bit more structured and then switch between the REL1_35 and REL1_39 branches respectively.

Are you interested in this and undo the pull request or should I insert the commits for the REL1_35 branch as it is now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants